Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name convention for mpdf-variables #39

Open
Klap-in opened this issue Jul 20, 2017 · 0 comments
Open

name convention for mpdf-variables #39

Klap-in opened this issue Jul 20, 2017 · 0 comments

Comments

@Klap-in
Copy link
Contributor

Klap-in commented Jul 20, 2017

mpdf variables are handled since the mpdf 7.0 version as values with are defined in the $config array.

See
/configuration/configuration-v7-x.html
/reference/mpdf-variables/overview.html
/reference/mpdf-functions/construct.html

The naming of the mpdf-variables is not consistent. What would be a preferred manner?

Now in use are:

  • the variable string <a href="{{ "/reference/mpdf-variables/aliasnbpggp.html" | prepend: site.baseurl }}">aliasNbPgGp</a>
    -> [aliasNbPgGp]
  • the variable <span class="parameter">$aliasNbPgGp</span>
    -> [$aliasNbPgGp]
  • The <a href="{{ "/configuration/configuration-v7-x.html" | prepend: site.baseurl }}">configuration variable</a> ``useActiveForms`` should be set ...
    -> [configuration variable] useActiveForms

Some thoughts:

  • I now prefer the first option. But from that layout it is not direct visible that it is a link to /reference/mpdf-variable/...
  • adding $ before all variables looks not logic, because some variable may only be used as configuration parameter in the $config array of the constructor.
  • $variablename is also bit different than the actual syntax, $mpdf->variablename.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant