Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preferenceComparison filter object does not validate it's inputs: KeyError: 'pref' #2284

Open
mythmon opened this issue Nov 3, 2020 · 0 comments

Comments

@mythmon
Copy link
Contributor

mythmon commented Nov 3, 2020

https://sentry.prod.mozaws.net/operations/normandy-prod/issues/9938952/?referrer=github_plugin

STR:

Make a type=preferenceComparison filter object where instead of pref=foo.bar, you provide preference=foo.bar.

KeyError: 'pref'
(15 additional frame(s) were not displayed)
...
  File "rest_framework/views.py", line 480, in raise_uncaught_exception
    raise exc
  File "rest_framework/views.py", line 506, in dispatch
    response = handler(request, *args, **kwargs)
  File "rest_framework/mixins.py", line 56, in retrieve
    return Response(serializer.data)
  File "rest_framework/serializers.py", line 548, in data
    ret = super().data
  File "rest_framework/serializers.py", line 246, in data
    self._data = self.to_representation(self.instance)

KeyError: 'pref'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant