Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit all slugs to 80 characters #2146

Open
mythmon opened this issue Mar 18, 2020 · 3 comments
Open

Limit all slugs to 80 characters #2146

mythmon opened this issue Mar 18, 2020 · 3 comments

Comments

@mythmon
Copy link
Contributor

mythmon commented Mar 18, 2020

Normandy slugs get used in a lot of places, that have various limits. The most restrictive one we know about is Events, where we use the recipe's slug as the Event's value field. That field is limited by telemetry to 80 characters.

The client will safely truncate these fields, but that makes for confusing telemetry. We should limit this on the server.

There is one recipe that currently has a slug longer than 80 characters, recipe 326. Since this is an old recipe that isn't active anymore, I think it is fine. If we end up with problems we can revise that recipe to shorten the slug without issue.

@jaredlockhart
Copy link
Collaborator

@mythmon I just checked with sunah and she linked me to the current telemetry docs that indicate the limit is now 100 characters:

https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/environment.html#experiments

Are you sure the events limit is still 80?

@mythmon
Copy link
Contributor Author

mythmon commented Mar 18, 2020

@jaredlockhart
Copy link
Collaborator

@mythmon you are correct we should limit it to 80 everywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants