Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatibility with sqlalchemy 2.x #1199

Open
jcristau opened this issue Aug 27, 2024 · 0 comments
Open

incompatibility with sqlalchemy 2.x #1199

jcristau opened this issue Aug 27, 2024 · 0 comments

Comments

@jcristau
Copy link
Contributor

jcristau commented Aug 27, 2024

The sqlalchemy upgrade broke tooltool uploads: check_pending_upload would say "Upload of [hash] considered valid" but never actually seems to add the FileInstance to the db, so the uploaded file never becomes visible.

We reverted to 1.4.x (#1191), but we should probably look at fixing this (and. if I can dream, having better test coverage...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant