Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figure out what to do with logins #10

Open
bhearsum opened this issue Dec 10, 2019 · 3 comments
Open

figure out what to do with logins #10

bhearsum opened this issue Dec 10, 2019 · 3 comments

Comments

@bhearsum
Copy link
Contributor

Even after #9 is fixed, login will be broken because the /auth0 endpoints don't exist. We probably need to change auth to talk directly to Taskcluster, although this needs a bit more investigation first.

@bhearsum
Copy link
Contributor Author

I was talking to @rail about this and he pointed out that none of the UI interactions use backend endpoints that require auth. So we can just rip out the frontend login stuff instead of trying to fix it. I'm guessing it only exists because this used to be integrated with the common releng frontend code in the services repo.

@bhearsum bhearsum changed the title login is broken remove login button and associated code Dec 12, 2019
@bhearsum
Copy link
Contributor Author

I was poking at unrelated things today and realized that downloads of internal artifacts from the UI don't work if you're not logged in. I can't confirm that they do work if you are logged in, but presumably a session cookie would be set in that case, and they would.

So, now I'm not sure whether or not we can rip out logins.

@bhearsum bhearsum changed the title remove login button and associated code figure out what to do with logins Dec 12, 2019
@bhearsum
Copy link
Contributor Author

I ended up making logins work, but internal artifact downloads still do not. This is because the links to them are simple tags, which can't include an Authorization header. I think it's possible to change the frontend to download with an XHR request after a bit of research, but I don't know if it's worthwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant