Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signingscript: sign_authenticode_file can't check if MSIX is already signed #376

Open
agashlin opened this issue Jul 20, 2021 · 0 comments

Comments

@agashlin
Copy link

Since mozilla-releng/winsign#23 , winsign supports signing MSIX files with makemsix. signingscript checks whether a file is already signed with winsign.osslsigncode.is_signed(), which is not effective with the Zip-based MSIX. winsign should probably expose a generic is_signed() function that can check PE/MSI via winsign.osslsigncode.is_signed() or MSIX via winsign.makemsix.is_signed() (which does not yet exist).

osslsigncode just can't make sense of the file, is_signed() always returns False, so I don't think this causes any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants