Dropdown in header nav not working

[stacymoorhead]

Hello! I've made it to section 5 and upon working on the js for the drop downs I've noticed they're not working. At first I thought it was my error, but after switching to master branch I've noticed it's not working there either. I'm not that advanced yet with js so I'm not sure where the problem is occurring. I decided to work with your copy of _S and not download the latest version since this is my first try at the tutorial.

[mojenmojen]

+1. The dropdown menus are not working in the exercise files on Lynda.com, and they also don't work with the files here.

Edited to add: I figured out a workaround and submitted a pull request. I don't know if it's the best way to solve the problem but it does work.

[antpearson]

Didn't work for me either but your fix worked @mojenmojen, thanks!

[nicollehahn]

Thanks, @mojenmojen, your fix worked for me also!

[frontenddevguy]

Duplicating my response from da5id5's issue:

That should say .children.toggled-on and is incorrectly specified as .sub-menu.toggled-on as far as the branch I am currently at (06_05).

navigation.js specifies both:
_this.next( '.children, .sub-menu' ).toggleClass( 'toggled-on' );

It could be an _s update to class_walker (class-walker-nav-menu-checklist.php)
public function start_lvl( &$output, $depth = 0, $args = array() ) { $indent = str_repeat( "\t", $depth ); $output .= "\n$indent<ul class='children'>\n"; }

This requires that we are merging in our local changes :)

[JimDoubleU]

Thank you @mojenmojen for the fix. : )