Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Income vs Expenses report #2832

Closed
1 of 2 tasks
vomikan opened this issue Jan 28, 2021 · 5 comments
Closed
1 of 2 tasks

Income vs Expenses report #2832

vomikan opened this issue Jan 28, 2021 · 5 comments
Assignees
Milestone

Comments

@vomikan
Copy link
Member

vomikan commented Jan 28, 2021

MMEX version:

  • 1.3.7
  • 1.3.6

I've created separate DB with incomes only then run "Income vs Expenses - Monthly" report with "Overtime" parameter
image

I expect to see one green bar in a month, but I see two. The second one has a strange, very big meaning.

Version: 1.3.7-RC.1 64-bit
• db 7 • (aes128cbc)

Libs:
• wxWidgets 3.1.4 (wxMSW 10.0)
• wxSQLite3 4.6.0 (SQLite 3.31.1)
• RapidJSON 1.1.0
• Lua 5.3.5
• libcurl/7.61.0-DEV WinSSL

Build: Jan 25 2021 11:03:49
• CMake 3.16.2
• MSBuild 15.9.21.664
• gettext 0.19.8.1
• MSVS15.0
• MSVSC 19.16.27035.0
• Windows SDK 10.0.14393.0

OS:
• Windows 10 (build 18363), 64-bit edition
• Russian (windows-1251)

@vomikan
Copy link
Member Author

vomikan commented Jan 28, 2021

Reason of this issue sample:

,{ name: 'Expenses', data: [0,000000,0,000000,0,000000,0,000000,0,000000,0,000000,0,000000,0,000000,0,000000,0,000000,0,000000,0,000000,0,000000,0,000000,0,000000,0,000000,0,000000,0,000000] }] }

but should be:

, data: [0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000] }] }

comma is data and value separator at the same time.

@vomikan vomikan added the good first issue good issue for first-time contributors - please fix me ASAP label Jan 28, 2021
@vomikan vomikan added this to the v1.3.7 milestone Jan 28, 2021
@vomikan
Copy link
Member Author

vomikan commented Jan 28, 2021

In case if Decimal symbol has been changed to dot
image
the graph became okey
image

@whalley
Copy link
Member

whalley commented Jan 28, 2021

Yes, a locale-specific issue. I see where the error is. Will affect other reports also. Will get a fix done.

@vomikan
Copy link
Member Author

vomikan commented Jan 28, 2021

@whalley
Please be so kind as to see what possible fix. I'm very busy this week.

vomikan added a commit that referenced this issue Jan 28, 2021
fix(#2832): chartdata now locale independent
@vomikan vomikan added fixed and removed good first issue good issue for first-time contributors - please fix me ASAP labels Jan 28, 2021
@vomikan
Copy link
Member Author

vomikan commented Jan 28, 2021

Related issue
moneymanagerex/general-reports#64

@vomikan vomikan closed this as completed Jan 29, 2021
@vomikan vomikan mentioned this issue Feb 3, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants