Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI hangs if monerod cannot bind #4240

Open
hinto-janai opened this issue Nov 7, 2023 · 2 comments · May be fixed by #4244
Open

GUI hangs if monerod cannot bind #4240

hinto-janai opened this issue Nov 7, 2023 · 2 comments · May be fixed by #4244

Comments

@hinto-janai
Copy link

When starting monero-wallet-gui and starting a local node, it will hang with no indication/error/log if monerod itself cannot bind, e.g:

2023-11-07 17:44:20.109	E ZMQ bind failed: Address already in use
2023-11-07 17:44:20.121	E Exception in main! Failed to add TCP socket(127.0.0.1:18082) to ZMQ RPC Server

Reproduce

  1. Start something on ZMQ/RPC port
  2. Start monero-wallet-gui and launch local node
  3. monero-wallet-gui hangs forever attempting to launch monerod which cannot bind

image

Something could be logged if monerod exits with non-zero.
@plowsof
Copy link
Contributor

plowsof commented Nov 12, 2023

after 120 seconds i get a notification that the daemon failed to start. does this scenario fool the checks? (i bound an rpc wallet to 18083 and launched monerod in from the gui with --zmq-pub tcp://127.0.0.1:18083 )

@hinto-janai
Copy link
Author

Interesting - if that flag (or any flag I'm assuming) is passed, it will properly error:

image

This doesn't happen without a flag though, port blocked with no flag will hang forever - maybe this error should be copy+pasted here. I'll try fixing this later.

@hinto-janai hinto-janai linked a pull request Nov 14, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DaemonManager: prevent GUI from hanging on hanging monerod launch hinto-janai/monero-gui
2 participants
@plowsof @hinto-janai