Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Moment Timezone requires Moment.js" error when using Node package #838

Closed
4lp opened this issue May 1, 2020 · 12 comments
Closed

"Moment Timezone requires Moment.js" error when using Node package #838

4lp opened this issue May 1, 2020 · 12 comments

Comments

@4lp
Copy link

4lp commented May 1, 2020

Moment-timezone 0.5.23 throws the following error when attempting to use:

Moment Timezone requires Moment.js.

I have attempted to upgrade to the latest package version but it doesn't solve the issue. In researching, I found that it's probably related to moment/moment#5481 since moment is a dependency.

Would it be possible/a good idea to change the moment version in the package.json file to exclude the versions of moment which cause this issue?

Thanks!

@simplecommerce
Copy link

I have the same issue here.

@phillt
Copy link

phillt commented May 1, 2020

Broke our page as well:

image

@voltaaage
Copy link

Broke ours as well

Screen Shot 2020-05-01 at 6 23 21 PM

@btmurrell
Copy link

+1

1 similar comment
@consciousweb
Copy link

consciousweb commented May 2, 2020

+1

@ghost
Copy link

ghost commented May 2, 2020

Previous issue #837 fix worked for me.

@laddhadhiraj
Copy link

+1

@rinick
Copy link

rinick commented May 3, 2020

for now just rollback to 2.24
if you need another package that already depends on 2.25, update package.json's resolutions

  "resolutions": {
    "**/moment": "2.24.0"
  },

@ariel262626
Copy link

Setting moment version to "2.24.0" fixed it for me

@mitskevich
Copy link

Upgrading moment to 2.25.3 fixed it for me. I had the same issue with moment >2.24.0 <=2.25.2 and moment-timezone 0.5.28.

@onlythinking
Copy link

+1,I also encountered the same problem

@4lp
Copy link
Author

4lp commented May 5, 2020

Fixed since moment 2.25.3 got released

@4lp 4lp closed this as completed May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests