Fix incorrect creation of CommandSyntaxException with cause
#828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `initCause` was failing because `CommandSyntaxException` is created by Brigadier in a way which does not permit setting a cause. Therefore, now instead add the cause exception as 'suppressed'.
violine1101
approved these changes
Jul 20, 2024
|
Thanks! Fyi, we may up removing this command altogether since we don't need it very often anymore, so it isn't a huge issue that it doesn't work right now. But in case we do want to keep it this'll help us understand what's going wrong with it at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #786
At least the
IllegalStateExceptionthrown byinitCause; the reason why the activity search failed in the first place is a different issue (and I don't know the reason for that at the moment)Approach
Use
Throwable#addSuppressedinstead ofThrowable#initCauseChecklist
and
docsfolder