Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto rerun if all students are not allocated #81

Open
B-kash opened this issue Apr 26, 2024 · 2 comments
Open

Auto rerun if all students are not allocated #81

B-kash opened this issue Apr 26, 2024 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@B-kash
Copy link

B-kash commented Apr 26, 2024

Summary

On the readme file it says

Run the program and re-run if

  • Any school has students who have not been assigned a center.

This feels very weird.

It would be very userfriendly if all the students are allocated on the single go.

Proposed solution

Keep the list of students that are not allocated and try allocating them if they are not allocated at the end of the run.

@sumanashrestha sumanashrestha added enhancement New feature or request help wanted Extra attention is needed labels May 5, 2024
@sumanashrestha sumanashrestha changed the title Allocation of all the students should be done in a single run Auto rerun if all students are not allocated May 5, 2024
@sumanashrestha
Copy link
Collaborator

The way this is implemented, allocation of all students cannot be guaranteed. However we may re run the app until all students are allocated.
We would also need to set a max retry count (say 10) and show error message if it fails more than that. In such case we need to revisit to see if more centers need to be added or more capacity is needed

@B-kash
Copy link
Author

B-kash commented May 13, 2024

I have created a PR with the changes. This should rerun default 10 times if the allocation failed and also the retries can be updated with the arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants