Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe there are some typos #1

Open
kanition opened this issue May 31, 2021 · 7 comments
Open

Maybe there are some typos #1

kanition opened this issue May 31, 2021 · 7 comments

Comments

@kanition
Copy link

kanition commented May 31, 2021

<title id="MathJax-SVG-1-Title">x squared plus y squared minus z squared equals negative 1 comma</title>

I really like this amazing work and thank you for your sharing this book!

I have a problem with the implicit form of the hyperboloid:
It is x^2+y^2-z^2=-1, which means that it is a two-sheet hyperboloid.
But the parametric form shows that it is generated by a rotating line passing through points (x1,y1,z1) and (x2,y2,z2),
which should be a one-sheet hyperboloid.
Maybe the implicit form of the hyperboloid should be changed to x^2+y^2-z^2=1 for consistency.

Reference:https://en.wikipedia.org/wiki/Hyperboloid

@kanition
Copy link
Author

kanition commented Jun 1, 2021

(analogous to a handle of a teacup). On a triangle mesh, the number of edges and
vertices is furthermore related by the identity
</p>

Maybe there is another typo: I guess you meant "the number of edges and faces ... "

@kanition
Copy link
Author

kanition commented Jun 1, 2021

</svg> to the right of the line,
zero for points on the line, and negative for points to the left of the

<p>The edge function gives a positive value for points to the left of the
line, and negative value for points to the right. Thus, if a point has

Maybe Figure 3.14 and its caption are inconsistent with the text. It should be:
Left to the line: e(p)>0
Right to the line: e(p)<0
On the line: e(p)=0

@kanition kanition changed the title Problem about the implicit form of the hyperboloid Maybe there are some typos Jun 1, 2021
@kanition
Copy link
Author

kanition commented Jun 9, 2021

<tt>PREV(k)</tt>th edges of the <tt>i</tt>th child need to be set. To set the <tt>k</tt>th

Maybe you mean that "......the kth and PREV(k)th edges of the kth child need to be set"——
"ith child" should be changed to "kth child".

@kanition
Copy link
Author

https://github.com/mmp/pbr-book-website/blob/02b496ae12670f8ffec2a6fe67cc30b07e57cba6/3ed-2018/Shapes/Managing_Rounding_Error.html#L1757

With e_b=255, non-zero significand bits correspond to special NaN values...

It should be "e=255" rather than "e_b=255".

@kanition
Copy link
Author

kanition commented Jul 6, 2021

@Connor24601
Copy link

Hi @kanition,
Fellow reader here. In the preface, the book states

As with earlier versions of the book, please send an email to [email protected] if you see any errors in the text or in the online conversion of it.

I recommend shooting them an email with this issue linked, if you haven't already.

@kanition
Copy link
Author

Thank you for your advice. I'll try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants