Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay the exercise/timer completition until the end of the last breathing cycle iteration #55

Open
ghost opened this issue Aug 7, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ghost
Copy link

ghost commented Aug 7, 2020

Hey!
This app has become almost perfect since you have added the voice guiding option. But there is just one imperfection: the countdown timer stops the session right when the time reaches 0. But it would be really great if it would stop when the last full cycle is done. I mean, there is always an occasion when I breathes in, holds and then there is the end of the session suddenly.

Thank you for you work!

@mmazzarolo mmazzarolo changed the title Countdown timer finishes the breathing cycle before the actual end of it Delay the exercise/timer completition until the end of the last breathing cycle iteration Aug 7, 2020
@mmazzarolo
Copy link
Owner

Hey @nikkpark ! :D Thanks for the feedback. Yeah, that's a good catch.
I'm keeping the issue open. If anyone is willing to contribute, I'm open to help! Otherwise I can work on it if/when I have some spare time 👍

@mmazzarolo mmazzarolo added the enhancement New feature or request label Aug 7, 2020
@mmazzarolo mmazzarolo added the good first issue Good for newcomers label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant