From 897bb3852caca62364d5dc6ddc746435f880e314 Mon Sep 17 00:00:00 2001 From: joeloskarsson Date: Thu, 5 Sep 2024 15:58:20 +0200 Subject: [PATCH 1/3] Clarify PR template --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index b4bf15ea..e523770a 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -26,7 +26,7 @@ - [ ] I have updated the [README](README.MD) to cover introduced code changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have given the PR a name that clearly describes the change, written in imperative form ([context](https://www.gitkraken.com/learn/git/best-practices/git-commit-message#using-imperative-verb-form)). -- [ ] I have requested a reviewer and an assignee (assignee is responsible for merging) +- [ ] I have requested a reviewer and an assignee (assignee is responsible for merging). This applies only if you have write access to the repo, otherwise feel free to tag a maintainer to add a reviewer and asignee. ## Checklist for reviewers From 435c8faf82811800ec2dbf6319f875bb2844d646 Mon Sep 17 00:00:00 2001 From: joeloskarsson Date: Thu, 5 Sep 2024 16:02:30 +0200 Subject: [PATCH 2/3] Fix typo --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index e523770a..9d4aeb54 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -26,7 +26,7 @@ - [ ] I have updated the [README](README.MD) to cover introduced code changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have given the PR a name that clearly describes the change, written in imperative form ([context](https://www.gitkraken.com/learn/git/best-practices/git-commit-message#using-imperative-verb-form)). -- [ ] I have requested a reviewer and an assignee (assignee is responsible for merging). This applies only if you have write access to the repo, otherwise feel free to tag a maintainer to add a reviewer and asignee. +- [ ] I have requested a reviewer and an assignee (assignee is responsible for merging). This applies only if you have write access to the repo, otherwise feel free to tag a maintainer to add a reviewer and assignee. ## Checklist for reviewers From f70ead53cbb86514ec81227ffc34dd759ddd045a Mon Sep 17 00:00:00 2001 From: joeloskarsson Date: Thu, 5 Sep 2024 16:09:16 +0200 Subject: [PATCH 3/3] Add changelog entry --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7348f6a0..b4f7eb07 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -35,6 +35,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed +- Clarify routine around requesting reviewer and assignee in PR template + [\#74](https://github.com/mllam/neural-lam/pull/74) + @joeloskarsson + - Argument Parser updated to use action="store_true" instead of 0/1 for boolean arguments. (https://github.com/mllam/neural-lam/pull/72) @ErikLarssonDev