Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent parameters #11

Open
MichaelMedek opened this issue Aug 8, 2024 · 0 comments
Open

Inconsistent parameters #11

MichaelMedek opened this issue Aug 8, 2024 · 0 comments

Comments

@MichaelMedek
Copy link

MichaelMedek commented Aug 8, 2024

The readme states

rtfm/README.md

Line 67 in 9884a6b

python scripts/utils/prepare_csv_for_eval.py --output_dir ./eval_tasks/my_task

python scripts/utils/prepare_csv_for_eval.py --output_dir ./eval_tasks/my_task

which gives

ERROR: The function received no value for the required argument: target_colname
Usage: prepare_csv_for_eval.py CSV OUT_DIR TARGET_COLNAME TO_REGRESSION

so output_dir should be out_dir and to_regression is missing, but mainly target_colname is missing. However if I provide it it gets ignored in

generate_files_from_csv(csv, out_dir, to_regression=to_regression)

And then overwritten and inferred here

target_colname = df.columns[-1]

target_colname = df.columns[-1]

To solve this, target_colname should be optional and only if not given, it should be inferred from df.columns[-1]. Also to_regression should have a default to_regression: bool = False. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant