We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I think that we should normalize the value to empty string if null is passed. If you need a working example, I'll provide it in the week end but it is pretty clear looking at https://github.com/minkphp/Mink/blob/master/src/Selector/NamedSelector.php#L208 and https://github.com/minkphp/Mink/blob/master/src/Selector/NamedSelector.php#L224
null
Basically, %locator% are never replaced and so no possible way to produce a valid xpath.
%locator%
If value normalization is note feasabe (as empty string could be a valid use case?) we should throw an exception.
If you all agree to replace null with empty string (or to throw an exception), I'll be happy to make a PR.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
I think that we should normalize the value to empty string if
nullis passed.If you need a working example, I'll provide it in the week end but it is pretty clear looking at
https://github.com/minkphp/Mink/blob/master/src/Selector/NamedSelector.php#L208
and
https://github.com/minkphp/Mink/blob/master/src/Selector/NamedSelector.php#L224
Basically,
%locator%are never replaced and so no possible way to produce a valid xpath.If value normalization is note feasabe (as empty string could be a valid use case?) we should throw an exception.
If you all agree to replace
nullwith empty string (or to throw an exception), I'll be happy to make a PR.The text was updated successfully, but these errors were encountered: