Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the named content selector even looks in javascript String literals #728

Open
jcalderonzumba opened this issue Dec 20, 2016 · 2 comments
Assignees

Comments

@jcalderonzumba
Copy link
Contributor

Finding elements with find('named', ['content', 'some string']) looks even in tags, and returns those elements if it does find an equivalent String literal anywhere in there. I don't think this should happen.

Opened in jcalderonzumba/MinkPhantomJSDriver#58 by @thedamnedrhino

@stof stof self-assigned this Dec 20, 2016
@aik099
Copy link
Member

aik099 commented Dec 20, 2016

Actually you might want to send PR to https://github.com/minkphp/driver-testsuite with new test checking that behavior across drivers.

If all drivers won't find HTML inside a JS, but PhantomJS will, then it's their bug.

@stof
Copy link
Member

stof commented Dec 20, 2016

@aik099 this is not related to a driver issue here. Drivers are not implementing the feature. Mink itself does (and then give a XPath query to drivers). This is something we should fix in Mink itself, in our NamedSelector (and so tests should go in the Mink testsuite too instead of using the whole functional stack).
I have an idea to improve the XPath to cover this, which is why I self-assigned on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants