Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated comments on PRs don't work #677

Open
asamalik opened this issue Jan 4, 2022 · 1 comment
Open

Automated comments on PRs don't work #677

asamalik opened this issue Jan 4, 2022 · 1 comment

Comments

@asamalik
Copy link
Contributor

asamalik commented Jan 4, 2022

Recently, @regexowl implemented a super helpful test that posts comments to PRs, checking for any potential errors in the configs.

This seemd to work great in all our tests, until someone else sent a PR and the test failed with the following error:

Unhandled error: HttpError: Resource not accessible by integration

It appears that this is a known limitation of GitHub Actions.

If anyone knows any way around this, please let me know!
asamalik added a commit that referenced this issue Jan 4, 2022
@asamalik
Disabling the automated PR comment, see #677
1e24a69
@asamalik
Copy link
Contributor Author

asamalik commented Jan 4, 2022

We could use pull_request_target instead of pull_request which would "work", but there are security caveats.

Here's more info with a potential solution.

keszybz pushed a commit to keszybz/content-resolver-input that referenced this issue Nov 2, 2022
@asamalik
Disabling the automated PR comment, see minimization#677
e00ec66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asamalik