Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some blocks are not displayed properly if image is say 32x1440 px and not animated(?) (water and lava is ok though) #8

Open
Fixer-007 opened this issue Apr 14, 2016 · 5 comments

Comments

@Fixer-007
Copy link

Found that problem on John Smith Legacy Modded
Water and lava in this special format work and display fine, but diamond lump and gold lump are not (they were probably animated in original).

DL: http://mods.curse.com/texture-packs/minecraft/223328-john-smith-legacy-modded

@ensonic
Copy link
Contributor

ensonic commented Nov 26, 2017

Maybe a dupe of #9 and see my 'fix' in #30

@Fixer-007
Copy link
Author

Fixer-007 commented Nov 26, 2017

Yeah it does fixes it, Mese Crystal seems broken (long texture):

Found: JohnSmithLegacy1122v4
   - File: John Smith Legacy 1.12.2 v4.zip
+items/bed.png beds_bed.png : Not Found
+blocks/bed_feet_end.png beds_bed_side_bottom.png : Not Found
+blocks/bed_feet_side.png beds_bed_side_bottom_r.png : Not Found
+blocks/bed_feet_side.png beds_bed_side_bottom_l.png h: Not Found
+blocks/bed_feet_top.png beds_bed_top_bottom.png : Not Found
+blocks/bed_head_end.png beds_bed_side_top.png : Not Found
+blocks/bed_head_top.png beds_bed_top_top.png : Not Found
+blocks/bed_head_side.png beds_bed_side_top_r.png : Not Found
+blocks/bed_head_side.png beds_bed_side_top_l.png h: Not Found
+items/boat.png boats_inventory.png : Not Found
+items/door_wood.png doors_item_wood.png : Not Found
+items/door_iron.png doors_item_steel.png : Not Found
+blocks/rail_normal.png default_rail.png : Not Found
+blocks/rail_normal_turned.png default_rail_curved.png : Not Found
composite.exe: unable to open image '_n/m.png': No such file or directory @ error/blob.c/OpenBlob/3109.
composite.exe:  `_n/o.png' @ error/composite.c/CompositeImageCommand/1613.
convert.exe: unable to open image '_n/o.png': No such file or directory @ error/blob.c/OpenBlob/3109.
convert.exe: no images defined `default_mineral_mese.png' @ error/convert.c/ConvertImageCommand/3275.
   - Conversion quality: 424 / 451
   - Pixel size: 32px

@ensonic
Copy link
Contributor

ensonic commented Nov 28, 2017

This is the output for me:

NOGUI=1 ./mcresconvert.sh ~/Downloads/minetest/JSTR_Modded_Universal.zip 
Found: JSTR_Modded_Universal
   - File: JSTR_Modded_Universal.zip
+items/boat.png boats_inventory.png : Not Found
   - Conversion quality: 450 / 451
   - Pixel size: 32px

I'll check the mese-crystals.

@Fixer-007
Copy link
Author

Fixer-007 commented Nov 28, 2017

I've used link from main page here https://www.johnsmithlegacy.co.uk (1.12.2)

@ensonic
Copy link
Contributor

ensonic commented Nov 30, 2017

Ah, this got some special treatment:
https://github.com/minetest-tools/mcresconvert/blob/master/mcresconvert.sh#L611
when converting from items, we always want to crop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants