Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseUri isn't honored by server #125

Open
shesmer opened this issue Apr 24, 2015 · 1 comment
Open

baseUri isn't honored by server #125

shesmer opened this issue Apr 24, 2015 · 1 comment

Comments

@shesmer
Copy link

shesmer commented Apr 24, 2015

I am trying to create a WebDAV based server that doesn't listen on the root and therefore I need a baseUri when setting up the server.
In doing so I noticed that the baseUri gets overwritten afterwards through this line in server.js
this.setBaseUri(this.guessBaseUri());
This will always set the baseUri to /

I was able to fix this by adding this line
if (!options.baseUri)
this.setBaseUri(this.guessBaseUri());

This causes the baseUri guessing only to happen when there wan't an explicit one set.

This of course is just a suggestion. :)

Can this please be fixed ?

@shesmer
Copy link
Author

shesmer commented Apr 25, 2015

If it is easier I can also generate a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant