-
-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 3 #626
Comments
I don't think dropping 12.x is a good idea. We should keep 12.x for at least as long as it isn't deprecated on AWS, and possibly offer some support for as long as it works at all without resorting to custom runtimes. As you can see at https://nodejs.org/en/about/releases/ , EOL for 12.x is next year. AWS promises to follow the upstream LTS lifetime, but might offer some support past that. |
The release of v3 is planned for 2022-04 which lines up perfectly with it's EOL. |
I would like to answer because I am very interested in the project. Node versions supportI agree with @nponeccop , because I think that the role of middy is to be a library usable in the AWS environment (and not only). A library doesn't have to use the latest technology, otherwise it will lose adoption by more people. Moreover, if we look at AWS they stop supporting Node 10 only at the end of the month, and haven't released a runner for Node 16 yet. I may be wrong, can you elaborate on your thinking @willfarrell ? :) TypescriptHave you thought about doing the v3 in typescript? It's becoming almost a standard today, and it would probably allow to keep several versions of node in // using "compilation", as it's already done here with babel, and above all it would increase the code quality (IMO). Would you mind if I tried to create middyts/core for the example? Minify... |
I don't see value in supporting versions of node that are no longer fit for production use. In the rare, and highly unlikely, case someone must upgrade to the latest version of middy but is required to run it on the oldest version of Node AWS during this small window they will likely already have transpiling in their own build step making this a non-issue. We plan to release annually to ensure we can take advantage of new features keeping the latest version of middy fast and secure as possible. Ideally the middy publish step doesn't have a transpiling step in it making it easier to debug any issues that arise in production. Middy v3 will not be released until AWS supports Node v16.
Nope, I don't know TypeScript and have no plans to learn. Pivoting to TypeScript would also exclude an entire community from being able to contribute and add additional complexity to the project making it hared to maintain. IMO
Middy has a MIT license, this allow you to do this. However, few others have already done this. |
@willfarrell Hi, we are currently using v1 of middy and want to upgrade. In the statements above you mention that aws sdk v3 is not likely to be supported. Is that statement still true? Are you planning an upgrade to aws sdk v3 outside of middy v3 if so? |
@steelerc69 Currently That said, the code for using |
TypeScript + ESM is a nightmare atm... it's just a another unnecessary language that don't work anywhere and must be compiled to javascript to run. it's very much possible to have type safety and avoid all the need of compiling using jsdoc |
alpha is now released |
Just a collection of ideas for now.
Planned
finally
phase. #622onError
Order of attaching middleware #707http-error-handler
getInternal
returnoriginalError
?request.error.originalError
->request.error.originalErrors
to allow bubble up of error arrays Sqs batch failure error stack #762internal
.applyMiddleware()
by meging into.use()
?.__middlewares
import httpHeaderNormalizer from '@middy/http-header-normalizer'
to exampless3-key-normalizer
andsqs-json-body-parser
forevent-normalizer
, add notice to v2 docsinternal
values change - document with examples3-object-response
http-content-encoding
http-error-handler
{...}
,{..., plugin:{...}}
The text was updated successfully, but these errors were encountered: