From dcdc8ae74c8c597a0c36ffcd81d19743dcf1a2bb Mon Sep 17 00:00:00 2001 From: Shi Chen Date: Mon, 18 Jul 2022 17:17:59 +0800 Subject: [PATCH] send telemetry for manual refresh --- extension/package.json | 13 +++++++++++-- extension/src/commands/Commands.ts | 16 ++++++++-------- .../src/commands/RefreshExternalCommand.ts | 19 +++++++++++++++++++ 3 files changed, 38 insertions(+), 10 deletions(-) create mode 100644 extension/src/commands/RefreshExternalCommand.ts diff --git a/extension/package.json b/extension/package.json index 434b3272d..a66134355 100644 --- a/extension/package.json +++ b/extension/package.json @@ -264,6 +264,11 @@ { "command": "gradle.refresh", "category": "Gradle", + "title": "Refresh Gradle Projects View" + }, + { + "command": "gradle.refresh.external", + "category": "Gradle", "title": "Refresh Gradle Projects View", "icon": { "light": "resources/light/refresh.svg", @@ -466,9 +471,13 @@ "when": "false" }, { - "command": "gradle.refresh", + "command": "gradle.refresh.external", "when": "gradle:extensionActivated" }, + { + "command": "gradle.refresh", + "when": "false" + }, { "command": "gradle.runBuild", "when": "gradle:extensionActivated" @@ -520,7 +529,7 @@ "group": "navigation@2" }, { - "command": "gradle.refresh", + "command": "gradle.refresh.external", "when": "view == gradleTasksView || view == gradleDefaultProjectsView", "group": "overflow@3" }, diff --git a/extension/src/commands/Commands.ts b/extension/src/commands/Commands.ts index d35fb755b..029174363 100644 --- a/extension/src/commands/Commands.ts +++ b/extension/src/commands/Commands.ts @@ -77,6 +77,7 @@ import { COMMAND_CREATE_PROJECT, COMMAND_CREATE_PROJECT_ADVANCED, CreateProjectC import { HideStoppedDaemonsCommand, HIDE_STOPPED_DAEMONS } from "./HideStoppedDaemonsCommand"; import { COMMAND_RELOAD_JAVA_PROJECT, ReloadJavaProjectsCommand } from "./ReloadJavaProjectsCommand"; import { COMMAND_RUN_TASKS, RunTasksCommand } from "./RunTasksCommand"; +import { COMMAND_REFRESH_EXTERNAL, RefreshExternalCommand } from "./RefreshExternalCommand"; import { ShowStoppedDaemonsCommand, SHOW_STOPPED_DAEMONS } from "./ShowStoppedDaemonsCommand"; export class Commands { @@ -134,15 +135,14 @@ export class Commands { ); this.registerCommand(COMMAND_CANCEL_BUILD, new CancelBuildCommand(this.client)); this.registerCommand(COMMAND_CANCEL_TREE_ITEM_TASK, new CancelTreeItemTaskCommand()); - this.registerCommandWithoutInstrument( - COMMAND_REFRESH, - new RefreshCommand( - this.gradleTaskProvider, - this.gradleBuildContentProvider, - this.gradleTasksTreeDataProvider, - this.recentTasksTreeDataProvider - ) + const refreshCommand = new RefreshCommand( + this.gradleTaskProvider, + this.gradleBuildContentProvider, + this.gradleTasksTreeDataProvider, + this.recentTasksTreeDataProvider ); + this.registerCommandWithoutInstrument(COMMAND_REFRESH, refreshCommand); + this.registerCommand(COMMAND_REFRESH_EXTERNAL, new RefreshExternalCommand(refreshCommand)); this.registerCommand(COMMAND_LOAD_TASKS, new LoadTasksCommand(this.gradleTaskProvider)); this.registerCommandWithoutInstrument( COMMAND_REFRESH_DAEMON_STATUS, diff --git a/extension/src/commands/RefreshExternalCommand.ts b/extension/src/commands/RefreshExternalCommand.ts new file mode 100644 index 000000000..a9afdecb8 --- /dev/null +++ b/extension/src/commands/RefreshExternalCommand.ts @@ -0,0 +1,19 @@ +// Copyright (c) Microsoft Corporation. All rights reserved. +// Licensed under the MIT license. + +import { Command } from "./Command"; +import { RefreshCommand } from "./RefreshCommand"; + +export const COMMAND_REFRESH_EXTERNAL = "gradle.refresh.external"; + +/** + * Used for collecting telemetry of refresh command from external UI. + */ +export class RefreshExternalCommand extends Command { + constructor(private refreshCommand: RefreshCommand) { + super(); + } + async run(): Promise { + this.refreshCommand.run(); + } +}