Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for new icon for the"Opening Remote Repository" Scenario #149

Open
bhavyaus opened this issue Nov 11, 2022 · 7 comments
Open

Request for new icon for the"Opening Remote Repository" Scenario #149

bhavyaus opened this issue Nov 11, 2022 · 7 comments
Assignees

Comments

@bhavyaus
Copy link

Hi,

We have added a quick access icon on the primary side bar for Remote Repositories so that users can quickly open a remote github/azure repo. See #139

Currently, its the + icon which could confuse users since that implies "Adding/Creating" where as the action involved is "Opening"

image

Thank you!

@bhavyaus bhavyaus added the bug Issue identified by VS Code Team member as probable bug label Nov 11, 2022
@bhavyaus bhavyaus changed the title Request to add new icon for "Opening Remote Repository" scenario Request for new icon for the"Opening Remote Repository" Scenario Nov 11, 2022
@bhavyaus bhavyaus removed the bug Issue identified by VS Code Team member as probable bug label Nov 11, 2022
@daviddossett
Copy link
Contributor

Taking both open-folder and vm-connect icons as inspiration, here's what I propose (in welcome page context to show difference from open-folder. Thoughts?

CleanShot 2022-11-21 at 16 02 39@2x

Icons together for reference:

CleanShot 2022-11-21 at 16 03 49@2x

@bhavyaus
Copy link
Author

bhavyaus commented Nov 22, 2022

LGTM. It matches the remote explorer Activity Bar Icon. Any idea why the Remote Hub Extension Icon is
image

https://marketplace.visualstudio.com/items?itemName=ms-vscode.remote-repositories

I should probably change that up too.
cc: @joyceerhl

@joyceerhl
Copy link

@daviddossett added that one in July this year microsoft/vscode-remote-repositories-github#209 (comment). I know we talked about doing a refresh of all the remote-ish extensions at some point though. The only concern I can think of is that the Open Remote Repository scenario does not take place over a remote connection, so that might be confusing to users (and is possibly why we went with the internet connection icon instead).

@daviddossett
Copy link
Contributor

That's a fair point @joyceerhl. We can continue using that signal metaphor for this folder icon too. In fact, I don't know why I didn't think to use that icon here. Blame the Monday brain, I suppose.

It just needs to be modified for use at the "normal" codicon size.

@daviddossett
Copy link
Contributor

A second pass:

CleanShot 2022-11-21 at 16 55 37@2x

CleanShot 2022-11-21 at 16 56 20@2x

@bhavyaus
Copy link
Author

@daviddossett added that one in July this year microsoft/vscode-remote-repositories-github#209 (comment). I know we talked about doing a refresh of all the remote-ish extensions at some point though. The only concern I can think of is that the Open Remote Repository scenario does not take place over a remote connection, so that might be confusing to users (and is possibly why we went with the internet connection icon instead).

But Remote Repositories is also accessible through the Remote Explorer which also is home to other remote development scenarios and that uses the >< symbols in the icon?

@joyceerhl
Copy link

Yeah that's a good point--the Remote Repos view has always been in the Remote Explorer, and its primary value add is to ensure that users do not lose their uncommitted changes in repositories that they have opened before. Maybe this means we reconsider whether 1. we need the view and 2. the view fits in the Remote Explorer, especially if we are storing uncommitted changes with Edit Sessions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants