Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported Simulation Parameters Link Doesn't Work #36

Open
ozcanmiraay opened this issue Sep 23, 2024 · 3 comments
Open

Supported Simulation Parameters Link Doesn't Work #36

ozcanmiraay opened this issue Sep 23, 2024 · 3 comments

Comments

@ozcanmiraay
Copy link

Hello! There is a statement in the README file: "The simulator supports a plethora of parameters for the simulation description which can be found here."

However, the link doesn't work: https://github.com/microsoft/vidur/blob/main/docs/launch_parameters.md

How can we solve this? Thanks!

@AgrawalAmey
Copy link
Contributor

@ozcanmiraay, we recently removed the docs page. All the params are now self documented, you can check them by running with -h flag.

@ozcanmiraay
Copy link
Author

@AgrawalAmey Thank you so much! Also, how can I see the supported bounds for each of the numeric parameters? E.g., is there an upper/lower bound for a parameter like scheduler_config_batch_size_cap or request_length_generator_config_max_tokens enforced by how the simulation was set up?

@nitinkedia7
Copy link
Collaborator

@ozcanmiraay, for models other than LLama3 ones, scheduler_config_batch_size_cap = 128 and request_length_generator_config_max_tokens = 4096 are the maximum. For llama3, the maximums are 512 and 16k respectively.
Some more details regarding this are available at https://github.com/microsoft/vidur?tab=readme-ov-file#supported-models .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants