[SF] HTTP client settings for Service Fabric?

[linmeng08]

Hi, how can I specify HTTP client settings for YARP proxy service running in Service Fabric cluster? For example:

1. Use a client certificate to connect to the destination endpoints
2. Customize HTTPS certificate validation for destination endpoint - e.g. validation certificate chain but ignore host name not matching error, as the destination endpoints are typically private IP address of the nodes like https://10.0.0.5:20012/269aec54-396c-4658-9790-4a7e6760a225/132621760379835038.

I can see the Proxy HTTP Client Configuration section has documentation on how to configure those settings for each cluster, but in case of Service Fabric the clusters are auto-discovered and not configured in the configuration files. In the SF service enlistment section there is option for specifying HTTP request settings (timeout, etc) for the backend services but no client certificates and other settings.

Is using a Custom IProxyHttpClientFactory the suggested way for this?

[Tratcher]

Here's the code that maps those options (new in preview 10, #787):

reverse-proxy/src/ReverseProxy.ServiceFabric/ServiceDiscovery/Util/LabelsParser.cs

Lines 310 to 326 in c3c0407

	HttpClient = new ProxyHttpClientOptions
	{
	DangerousAcceptAnyServerCertificate = GetLabel<bool?>(labels, "YARP.Backend.HttpClient.DangerousAcceptAnyServerCertificate", null),
	MaxConnectionsPerServer = GetLabel<int?>(labels, "YARP.Backend.HttpClient.MaxConnectionsPerServer", null),
	ActivityContextHeaders = !string.IsNullOrEmpty(activityContextHeadersLabel) ? Enum.Parse<ActivityContextHeaders>(activityContextHeadersLabel) : null,
	SslProtocols = !string.IsNullOrEmpty(sslProtocolsLabel) ? Enum.Parse<SslProtocols>(sslProtocolsLabel) : null,
	#if NET
	EnableMultipleHttp2Connections = GetLabel<bool?>(labels, "YARP.Backend.HttpClient.EnableMultipleHttp2Connections", null),
	RequestHeaderEncoding = !string.IsNullOrEmpty(requestHeaderEncodingLabel) ? Encoding.GetEncoding(requestHeaderEncodingLabel) : null,
	#endif
	WebProxy = new WebProxyOptions
	{
	Address = GetLabel<Uri>(labels, "YARP.Backend.HttpClient.WebProxy.Address", null),
	BypassOnLocal = GetLabel<bool?>(labels, "YARP.Backend.HttpClient.WebProxy.BypassOnLocal", null),
	UseDefaultCredentials = GetLabel<bool?>(labels, "YARP.Backend.HttpClient.WebProxy.UseDefaultCredentials", null),
	}
	//TODO: ClientCertificate =

Client certificates aren't supported in this model, you'll need to use a custom factory for those. #869 should make that easier.

[linmeng08]

Cool I will try it out, thanks @Tratcher !