Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code eval tool: Change the alert for when a user is deleting a criteria #5911

Open
srietkerk opened this issue Sep 4, 2024 · 3 comments · May be fixed by microsoft/pxt#10165
Open

Code eval tool: Change the alert for when a user is deleting a criteria #5911

srietkerk opened this issue Sep 4, 2024 · 3 comments · May be fixed by microsoft/pxt#10165

Comments

@srietkerk
Copy link
Contributor

When a user is deleting a criteria from their checklist, they get an alert asking if they're sure they want to delete the criteria. The alert is not the prettiest.

image

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://makecode.microbit.org/beta---eval
  2. Make a checklist
  3. Add criteria to that checklist
  4. Delete a criterium
  5. See the alert

Not sure if we want to just use a pop-up/modal here instead to make it look like expected behavior or if we just want to remove the alert and not give a pop-up here because deleting a criteria is not super detrimental to the user.

@eanders-ms
Copy link
Contributor

I think we need some way to protect against accidental deletion. A popup was an easy solution. Alternatively, and a superior design IMO, would be a notification that includes an undo button. You can find an example of this in Outlook:

image

@srietkerk
Copy link
Contributor Author

Ooh, yeah, I like that design!!

@eanders-ms
Copy link
Contributor

It should be straight forward to implement using the existing toasts. They support injecting JSX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants