Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add source generation #147

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add source generation #147

wants to merge 15 commits into from

Conversation

almostchristian
Copy link

  • Added source generation package Microsoft.Health.Fhir.CodeGeneration.
  • Updates shared libraries to multitarget netstandard2.0 which is required for source generators

Usage:

[GeneratedFhir("Models/Pokemon.StructureDefinition.json",
   TerminologyResources = new[] { "Models/PokemonType.CodeSystem.json", "Models/PokemonType.ValueSet.json" })]
public partial class Pokemon
{
}

Currently the FhirVersionInfo used for code generation is hard-coded to R4B, and I don't see any difference when it's R5.

Resolves #140

Christian Donn Sarmago Relacion and others added 15 commits August 9, 2023 11:43
Implement source generation
6a6c71e
updates
fc1e3f7
Change namespace of generated files to use assembly name and folder s…
27660db 
…tructure
Added sample resource with a custom enum.
772302b 
Removed Microsoft.OpenApi as a dependency for source generation.
Restore codegenerated regex for net7
3c927b4
Improve json processing
879db43
Improve code structure
4dd23ec
Remove testing configuration
d620ed8
@almostchristian
Refactored code generation to use custom attribute for generation.
88836ee 
Definition files are no longer required to be added as AdditionalFiles
@almostchristian
Regenerate snapshots from forge
d5b15dd
@almostchristian
Improve source gen error messages and added diagnostics
2153ef3
@almostchristian
Added readme
cefe191
@almostchristian
Change version to 1.0.0-alpha.1
7d181e2
Change namespace to Synapxe from Microsoft.Health.
990f503 
Add azure build pipeline
Revert "Change namespace to Synapxe from Microsoft.Health."
4c3b32c 
This reverts commit 990f503.
@ewoutkramer
Copy link
Contributor

@GinoCanessa - Hadn't seen this PR before, but I guess this needs to change quite a bit after the refactoring of the codegen to use StructureDefinition instead of the custom metadata structures....

@almostchristian
Copy link
Author

Most of my code changes is related to multitargeting to netstandard2.0 which is a requirement for source generators. But from what I saw from the experimental branch, this will not be simple.

@GinoCanessa
Copy link
Contributor

Hi Christian - it is on my list to re-review everything. I started looking into it yesterday and will be making sure your use case is not left out.

@GinoCanessa
Copy link
Contributor

GinoCanessa commented Jul 11, 2024 •
edited
Loading

Alright @almostchristian , the current contents of the experimental branch should have all libraries correctly multi-targeting both .Net 8 and NetStandard 2.0. Note that you need a C# 12.0-compatible compiler to build them*. Please test and let me know if there are any issues.

*After we merge into main, I will finish sorting out the pipeline to release on NuGet as libraries and the CLI as a tool, so the build requirements are only until then.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Source generation for custom resources
3 participants
@almostchristian @ewoutkramer @GinoCanessa