Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix h-resume tests #83

Open
cleverdevil opened this issue Mar 14, 2018 · 2 comments
Open

Fix h-resume tests #83

cleverdevil opened this issue Mar 14, 2018 · 2 comments

Comments

@cleverdevil
Copy link

In these two h-resume tests:

  • tests/microformats-v2/h-resume/education.json
  • tests/microformats-v2/h-resume/work.json

... the education property contains a strange blend of h-card and h-event, which isn't documented in the spec, and seems incorrect. These should be fixed to be h-event with potential embedded h-card objects instead.

@jgarber623
Copy link
Member

So I just tried running the example markup in the following files…

  • tests/microformats-v2/h-resume/education.html
  • tests/microformats-v2/h-resume/work.html

…through the following Web-based parsers…

…and each one returned a result matching what's in the aforementioned JSON files.

Very strange. The h-resume/hresume examples are the only ones in the entire test suite where the type property has multiple values (h-card and h-event). There aren't very good examples on either of the pages (here and here) on the wiki, either.

🤔

@gRegorLove
Copy link
Member

I think the h-card should be embedded as a property of the h-event, like:

<div class="h-resume">
<p class="p-education h-event">
	<span class="p-location h-card"><span class="p-name p-org">The Queen's College, Oxford University</span></span>, 
	<span class="p-description">BA Hons (I) Physics</span> 
	<time class="dt-start" datetime="1973-09">1973</time><time class="dt-end" datetime="1976-06">1976</time>
</p>
</div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants