Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clap detection #151

Open
microbit-carlos opened this issue Mar 24, 2023 · 3 comments
Open

Clap detection #151

microbit-carlos opened this issue Mar 24, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@microbit-carlos
Copy link
Contributor

microbit-carlos commented Mar 24, 2023

CODAL has added a "clap" event, similar to "loud" and "quiet".

@microbit-carlos microbit-carlos added this to the 2.2.0 milestone Mar 24, 2023
@dpgeorge dpgeorge self-assigned this Aug 21, 2023
@microbit-carlos
Copy link
Contributor Author

For the set_threshold() method we'll need to throw an exception if the "clap" event is provided, as that threshold cannot be configured.

@dpgeorge
Copy link
Collaborator

SoundEvent.CLAP is added in 8b8c1d3

For the set_threshold() method we'll need to throw an exception if the "clap" event is provided,

This is also done (didn't need any changes, was already raising an exception for invalid sound events).

@microbit-carlos microbit-carlos added the enhancement New feature or request label Sep 3, 2024
@dpgeorge
Copy link
Collaborator

dpgeorge commented Sep 9, 2024

@microbit-carlos this is already done (see above). I tested it and it seems to work, microphone.get_events() does emit a SoundEvent.CLAP on occasion.

@dpgeorge dpgeorge assigned microbit-carlos and unassigned dpgeorge Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants