Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More options from ggplot for plotAbundanceDensity #122

Open
artur-sannikov opened this issue Jan 12, 2024 · 9 comments
Open

More options from ggplot for plotAbundanceDensity #122

artur-sannikov opened this issue Jan 12, 2024 · 9 comments

Comments

@artur-sannikov
Copy link

plotAbundanceDensity function does not accepts arguments from ggplot, for example jitter layout does not have width option and uses geom_point() as its basis but it does not accept geom_point options.

@antagomir
Copy link
Member

This issue should be moved to miaViz?

@artur-sannikov
Copy link
Author

artur-sannikov commented May 10, 2024

You are right. It's possible to transfer issues if you have write access.

@TuomasBorman TuomasBorman transferred this issue from microbiome/mia May 10, 2024
@TuomasBorman
Copy link
Contributor

Another thing is that it might be simper to modify the ggplot object that comes from the plotAbundanceDensity function (instead of adding new parameters). Can you check that option? If that is easier, then we could modify examples

@antagomir
Copy link
Member

You are right. It's possible to transfer issues if you have write access.

@artur-sannikov You are in miaverse-developers team and that has write access to miaViz. Does it work?

@antagomir
Copy link
Member

One limitation with ggplot is that changing the geom_* afterwards is not so handy (e.g from violin to boxplot). It is possible and perhaps it would be wise to first create & show an example of that and then think if that is too complex, justifying shortcuts.

@TuomasBorman
Copy link
Contributor

@artur-sannikov

  • Can you describe what was the idea of supporting more options (why we need support for these ggplot options)?
  • Can you create an example on how to get the desired behavior without modifying miaViz?

--> The we can decide if we add the support

@artur-sannikov
Copy link
Author

I think what I wanted to achieve is to have width and height parameters from this plot: https://ggplot2.tidyverse.org/reference/geom_jitter.html

library(tidyverse)
data(mpg)

ggplot(mpg, aes(x = cyl, y = hwy)) +
  geom_jitter(width=0.5, height=0.3)

Some arguments are set here.

@antagomir
Copy link
Member

See also
#142
#107
#90

@antagomir
Copy link
Member

Any volunteers to pick up this one (including the linked issues)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants