Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul plugin does not implement if the service is blank in watchOption #84

Open
leopay opened this issue Nov 9, 2022 · 1 comment
Open

Comments

@leopay
Copy link

leopay commented Nov 9, 2022

in the registry option define

type WatchOptions struct {
// Specify a service to watch
// If blank, the watch is for all services
Service string
// Other options for implementations of the interface
// can be stored in a context
Context context.Context
}

but consul plugin seems not implement this

https://github.com/go-micro/plugins/blob/0d18e60b84eaff14af1ca32b70e3c32ec0637517/v4/registry/consul/watcher.go#L27-L55

@Davincible
Copy link
Contributor

That could very well be the case.
If you have some time, feel free to implement this yourself, contributions are very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants