Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metal-dom] handle edge cases selectors in toElement #378

Open
gcmznt opened this issue May 18, 2018 · 0 comments
Open

[metal-dom] handle edge cases selectors in toElement #378

gcmznt opened this issue May 18, 2018 · 0 comments
Labels

Comments

@gcmznt
Copy link
Contributor

gcmznt commented May 18, 2018

the method toElement here does not handle in a correct way selectors as #id>.class that are written without spaces.

the problem is in the if on lines 768-771.

we need to handle this edge cases as selectors starting with an # and with one character as >, ~ or + inside the string.

I am working on the fix for this issue

gcmznt added a commit to gcmznt/metal.js that referenced this issue May 18, 2018
@jbalsas jbalsas added the bug label May 18, 2018
jbalsas added a commit that referenced this issue Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants