Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write testcases #42

Open
mssun opened this issue Aug 2, 2018 · 3 comments
Open

Write testcases #42

mssun opened this issue Aug 2, 2018 · 3 comments
Labels
good first issue Good for newcomers

Comments

@mssun
Copy link
Contributor

mssun commented Aug 2, 2018

Current test code coverage is pretty low (about 13.56%): https://codecov.io/gh/mesalock-linux/mesabox/tree/master

Our target coverage is around 80%.
@mssun mssun added the good first issue Good for newcomers label Aug 2, 2018
@Arcterus
Copy link
Contributor

Arcterus commented Aug 2, 2018

The coverage significantly dropped after the tests were refactored (and it’s clearly wrong right now as the parser for sh says 0%).

@Arcterus
Copy link
Contributor

Arcterus commented Aug 2, 2018

There’s more tests for sh in the sh-parser branch btw.

@mssun
Copy link
Contributor Author

mssun commented Aug 2, 2018

The coverage significantly dropped after the tests were refactored (and it’s clearly wrong right now as the parser for sh says 0%).

This is wired and needs more investigation...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Arcterus @mssun