Skip to content
This repository has been archived by the owner on Feb 18, 2019. It is now read-only.

Latest commit

 

History

History
64 lines (36 loc) · 3.35 KB

CONTRIBUTING.md

File metadata and controls

64 lines (36 loc) · 3.35 KB
Raw

Contributing to EasyReact

We love contributions to the EasyReact project and request you follow the guidelines below. If you have any questions, or need any help, contact us on EasyReact Team.

Table of Contents

Getting Started

To get started, you will need to open a Terminal and:

  1. Fork this repo and clone it onto your machine.

    $ git clone https://github.com/YOUR_GITHUB_ID/EasyReactSwift

  2. Make changes to code, usually by tackling an issue. A list of issues can be found ISSUE.

    If there aren't any tagged issues, mail to EasyReact Team. and the team would be happy to help you get started.

  3. All source code submitted requires an Apache License header at the top of the file. This text can be found Here, just copy and paste it at the top of any new files you're submitting.

  4. Ensure all tests pass with your changes and test coverage must greater than before. If there is any new functionality introduced by your changes, new test case(s) may be required. If you need any help writing tests, contact us on EasyReact Team.

  5. Commit message should conform to commit message templates.

  6. If the tests all pass, open a Pull Request following the guidelines below.

Pull Requests

Note: Before opening a Pull Request, please run the tests and check them all pass and keep test coverage greater than or equal before.

EasyReact uses Continuous Integration. You may see mentions of Travis CI in your PR and its comments. Travis is an external service we use that is automatically called on every PR, and runs the test cases on macOS and iPhone simulator to ensure every code change is stable.

To open a new Pull Request, the GitHub website provides the simplest experience for new users. Go to your fork of the repo and click the New pull request button. You will be presented with a page featuring base fork: and base:, then an arrow, and then head fork: compare:. Make sure compare: has your branch with your changes selected and base: has master selected. When you are ready to open the PR, click the green button at the top called Create pull request.

When opening a PR, please:

  1. Create minimal differences and do not reformat the code. If you feel the codes structure needs changing, open a separate PR.
  2. Check for unnecessary white space using git diff --check before you commit your code.

Asking Questions

If you have any questions, mail to EasyReact Team. Comment on existing issues, or raise new ones if you discover something.

Reporting Issues

See the issue template.

Additional Resources