From 970141b133342c6de1947ba8e14c6d95a4c8e096 Mon Sep 17 00:00:00 2001 From: Marcel Frankruijter Date: Thu, 15 Nov 2018 10:01:20 +0100 Subject: [PATCH 1/2] Bugfix: temporarily disable dependency guard Due to an issue in dependency guard, circular dependencies cause an infinite loop. When this issue is fixed, it will be re-added. --- composer.json | 1 - 1 file changed, 1 deletion(-) diff --git a/composer.json b/composer.json index aaa70c3..a803166 100644 --- a/composer.json +++ b/composer.json @@ -27,7 +27,6 @@ "mediact/coding-standard-phpstorm": "~1.0", "mediact/composer-dependency-installer": "^1.0", "mediact/composer-file-installer": "^1.0", - "mediact/dependency-guard": "^1.0", "phpro/grumphp": "~0.1", "phpstan/phpstan": "~0.1", "phpunit/phpunit": "~3.7 || ~4.0 || ~5.0 || ~6.0 || ~7.0" From dbaa1d62d413d9535e7688dd73aee6d4993e6630 Mon Sep 17 00:00:00 2001 From: Marcel Frankruijter Date: Thu, 15 Nov 2018 10:09:50 +0100 Subject: [PATCH 2/2] Bugfix: disabled dependecy guard in grumphp.yml --- config/default/grumphp.yml | 76 +++++++++++++++++++------------------- 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/config/default/grumphp.yml b/config/default/grumphp.yml index 638ed84..41ec0cb 100644 --- a/config/default/grumphp.yml +++ b/config/default/grumphp.yml @@ -32,42 +32,42 @@ parameters: config_file: ./phpunit.xml metadata: priority: 200 - dependency-guard: - metadata: - priority: 100 - -services: - mediact.dependency_guard.exporter.factory: - class: Mediact\DependencyGuard\Composer\Command\Exporter\ViolationExporterFactory - - mediact.dependency_guard.exporter: - class: Mediact\DependencyGuard\Exporter\ViolationExporterInterface - factory: 'mediact.dependency_guard.exporter.factory:create' - arguments: - - '@console.input' - - '@console.output' - - mediact.dependency_guard.factory: - class: Mediact\DependencyGuard\DependencyGuardFactory - - mediact.dependency_guard.composer.io: - class: Composer\IO\BufferIO - - mediact.dependency_guard.composer.factory: - class: Composer\Factory - - mediact.dependency_guard.composer: - class: Composer\Composer - factory: mediact.dependency_guard.composer.factory:createComposer - arguments: - - '@mediact.dependency_guard.composer.io' +# dependency-guard: +# metadata: +# priority: 100 - mediact.dependency_guard.grumphp.task: - class: Mediact\DependencyGuard\GrumPHP\DependencyGuard - arguments: - - '@mediact.dependency_guard.composer' - - '@mediact.dependency_guard.factory' - - '@mediact.dependency_guard.exporter' - tags: - - name: grumphp.task - config: dependency-guard +#services: +# mediact.dependency_guard.exporter.factory: +# class: Mediact\DependencyGuard\Composer\Command\Exporter\ViolationExporterFactory +# +# mediact.dependency_guard.exporter: +# class: Mediact\DependencyGuard\Exporter\ViolationExporterInterface +# factory: 'mediact.dependency_guard.exporter.factory:create' +# arguments: +# - '@console.input' +# - '@console.output' +# +# mediact.dependency_guard.factory: +# class: Mediact\DependencyGuard\DependencyGuardFactory +# +# mediact.dependency_guard.composer.io: +# class: Composer\IO\BufferIO +# +# mediact.dependency_guard.composer.factory: +# class: Composer\Factory +# +# mediact.dependency_guard.composer: +# class: Composer\Composer +# factory: mediact.dependency_guard.composer.factory:createComposer +# arguments: +# - '@mediact.dependency_guard.composer.io' +# +# mediact.dependency_guard.grumphp.task: +# class: Mediact\DependencyGuard\GrumPHP\DependencyGuard +# arguments: +# - '@mediact.dependency_guard.composer' +# - '@mediact.dependency_guard.factory' +# - '@mediact.dependency_guard.exporter' +# tags: +# - name: grumphp.task +# config: dependency-guard