Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSX] Threading is broken for multi-import menu actions #74

Open
meanmedianmoge opened this issue Sep 19, 2020 · 1 comment
Open

[OSX] Threading is broken for multi-import menu actions #74

meanmedianmoge opened this issue Sep 19, 2020 · 1 comment
Assignees
Labels
bug Something isn't working low priority MacOS

Comments

@meanmedianmoge
Copy link
Owner

Describe the bug
The application crashes upon selecting either Import Multiples or Import as a Version from the File menu. This can be circumvented be re-routing the menu action directly to the import backend. However, we'd like to retain the threading so it is functionally equivalent to SD multi-imports.

To Reproduce
Steps to reproduce the behavior:

  1. Open the Librarian
  2. Click on File > Import Multiple
  3. The application will crash
  4. See error

Expected behavior
Expected the threading to initialize properly and for non-SD patches to be imported correctly.

Desktop (please complete the following information):

  • Mac OSX 10.15.4

Additional context
Solved by removing the thread connection to the menu-actions. Use the current SD-related threading to debug behavior.

@meanmedianmoge meanmedianmoge added bug Something isn't working medium priority labels Sep 19, 2020
@meanmedianmoge meanmedianmoge self-assigned this Sep 19, 2020
@meanmedianmoge
Copy link
Owner Author

Putting in the temporary fix for now, such that menu action multi-imports are not threaded. Will move this over to the next project following the 1.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority MacOS
Projects
Status: Todo
Development

No branches or pull requests

1 participant