You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 3, 2022. It is now read-only.
Ideally, we should be able to specify which page handles to apply configuration generated css applies to, and the ability to implement multiple stylesheets.
For example, if generated CSS is to be used on the catalog_product_view handle, then that should be the only place that CSS is loaded.
I'd propose changing Meanbee_ConfigPoweredCss_Block_Css to inherit from Mage_Core_Block_Text_List and for child blocks to be implemented based on xml configuration where you can also specify what handles should be applied. i.e.
I can see this being beneficial though I don't have a complete idea of how this would be implemented yet.
My thoughts:
Is there a use case for needing a custom block type? We could modify it to be able to pass the page handle and it would generate a file based on that handle.
The generation process goes through each store, loads our block and saves the output of the _toHtml() to a file. This would need to change to presumably create a file for every page handle in your list that's saved in config.
You would then need a template for each page handle defined, so you would need to be aware to create a file in base/default, e.g. app/design/frontend/base/default/template/meanbee/configpoweredcss/catalog_product_view/css.phtml
The css files generated would then be skin/frontend/base/default/css/<page_handle>/meanbee_configpoweredcss_<store_id>.css
Does at a fair bit of complexity to it. I think we should be careful when adding this in to allow people to generate one file by default that's included on every request and still facilitate this functionality for those that would like it.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Ideally, we should be able to specify which page handles to apply configuration generated css applies to, and the ability to implement multiple stylesheets.
For example, if generated CSS is to be used on the
catalog_product_view
handle, then that should be the only place that CSS is loaded.I'd propose changing
Meanbee_ConfigPoweredCss_Block_Css
to inherit fromMage_Core_Block_Text_List
and for child blocks to be implemented based on xml configuration where you can also specify what handles should be applied. i.e.Thoughts?
The text was updated successfully, but these errors were encountered: