Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Auto-generated proto.ts should have async methods that returns promises #3

Open
lhr0909 opened this issue Oct 26, 2018 · 1 comment

Comments

@lhr0909
Copy link

lhr0909 commented Oct 26, 2018

loopbackio/loopback4-extension-grpc#31

We were evaluating if we could expose loopback v4 endpoints as gRPC endpoints, and found that the .proto.ts part of the code during auto-generation is not building methods that returns a promise. Currently we can have synchronous returns, but in the NodeJS world, we need these controller methods to be async so we can fetch data and return.

@lhr0909
Copy link
Author

lhr0909 commented Oct 26, 2018

#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant