Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only-in-en-us and external link classes conflict and add unnecessary whitespace #11434

Open
uiolee opened this issue May 25, 2024 · 6 comments · Fixed by mdn/translated-content#21711 · May be fixed by #11327
Open

only-in-en-us and external link classes conflict and add unnecessary whitespace #11434

uiolee opened this issue May 25, 2024 · 6 comments · Fixed by mdn/translated-content#21711 · May be fixed by #11327
Labels
has PR Issues that already have a PR idle p2 We want to address this but may have other higher priority items.

Comments

@uiolee
Copy link
Contributor

uiolee commented May 25, 2024

MDN URL

https://developer.mozilla.org/zh-CN/docs/Mozilla/Add-ons/WebExtensions/Your_first_WebExtension

与此议题相关的小节或标题？

https://developer.mozilla.org/zh-CN/docs/Mozilla/Add-ons/WebExtensions/Your_first_WebExtension#%E6%89%93%E5%8C%85%E5%92%8C%E5%8F%91%E5%B8%83

哪些信息是错误、无用或不完善的？

wrong layout. extra white space.

layout

你期望看到什么？

Generally speaking, you don't need that much white space between lines

你有什么支持的链接、参考或引用？

No response

你还想补充什么内容？

No response

MDN metadata

Page report details
@uiolee uiolee added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label May 25, 2024
@jasonren0403
Copy link
Contributor

This may be related to display: inline-block; on external links

image
image
image

I think it's a platform issue.

@jasonren0403 jasonren0403 removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label May 25, 2024
@jasonren0403
Copy link
Contributor

/cc @mdn/core-dev

@T34-active
Copy link

/cc @caugner, Please help move this issue to yari.

@yin1999 yin1999 mentioned this issue Jun 17, 2024
Merged
@yin1999
Copy link
Member

yin1999 commented Jun 17, 2024

I found the problem that caused this:

The link /zh-CN/docs/Mozilla/Add-ons/WebExtensions/Publishing_your_WebExtension has been redirected to https://extensionworkshop.com/documentation/publish/package-your-extension/, and the redirect rule only exists in the default locale. So the mutateLink() function will be called with the enUSFallback parameter been set, which result in the addition of only-in-en-us class. However, since the fallback link is an external link, the external class will also be added, and these two classes are conflicting.

I think it would be better to check the fallback link within the mutateLink() function.

I've created a PR (#21711) to fix this, but it still worth to resolve the conflicting in yari :)

@yin1999 yin1999 linked a pull request Jun 18, 2024 that will close this issue
Open
@jasonren0403
Copy link
Contributor

keep reopen unless fixed by yari side

@jasonren0403 jasonren0403 reopened this Jul 5, 2024
@uiolee
Copy link
Contributor Author

uiolee commented Jul 5, 2024

Maybe it should be moved to yari

@caugner caugner transferred this issue from mdn/translated-content Jul 8, 2024
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jul 8, 2024
@LeoMcA LeoMcA changed the title wrong layout in link only-in-en-us and external link classes conflict and add unnecessary whitespace Jul 23, 2024
@LeoMcA LeoMcA added p2 We want to address this but may have other higher priority items. has PR Issues that already have a PR and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jul 23, 2024
@github-actions github-actions bot added the idle label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has PR Issues that already have a PR idle p2 We want to address this but may have other higher priority items.
Projects
MDN translated-content l10n-zh
Status: Archive/Closed
Milestone
No milestone
5 participants
@LeoMcA @yin1999 @uiolee @jasonren0403 @T34-active