Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Compat gradle plugin "com.android.tools.build:gradle:3.3.0” in android studio 3.3. #21

Open
Guang1234567 opened this issue Jan 24, 2019 · 5 comments

Comments

@Guang1234567
Copy link

No description provided.

@Guang1234567 Guang1234567 changed the title [Enhancement] compat [Enhancement] Compat gradle plugin "com.android.tools.build:gradle:3.3.0” in android studio 3.3. Jan 24, 2019
@Guang1234567
Copy link
Author

Guang1234567 commented Jan 24, 2019

Hello dev:

Could you compat gradle plugin com.android.tools.build:gradle:3.3.0 in android studio 3.3 ?
And my gradle version is 4.10.1.

I met below error that not happen in com.android.tools.build:gradle:3.1.2 in android studio 3.1.4 :

Unable to load class 'org.gradle.api.internal.CollectionCallbackActionDecorator’.

@Guang1234567
Copy link
Author

Hello dev:

I fix it by upgrade gradle to v5.1.

7b5c099

BTY, thanks your plugin.

@adude3141
Copy link

As org.gradle.api.internal.CollectionCallbackActionDecorator was added with gradle 5.1,
this effectively means, that this latest version is only usable with gradle 5.1+.

Is this intended or an oversight?

@Guang1234567
Copy link
Author

Guang1234567 commented Jan 25, 2019

@adude3141

I don’t know. Gradle4.10 is the default config in Android Studio 3.3 that pass large test (maybe). So I will not change gradle version as a general rule. But sometime default gradle version maybe not work with your plugin unfortunately. ^_^

@adude3141
Copy link

Yes, of course.

But on the other hand, their might be constraints which prevent upgrading your project to gradle 5.1.

It might be intended, but as the docs still state the plugin to be compatible with gradle 2.1 I was wondering whether this is only an oversight and need to be fixed?

FYI @mdietrichstein

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants