Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query: should support multiple session IDs within one connection #1

Open
katrinafyi opened this issue Jul 19, 2024 · 0 comments · May be fixed by #2
Open

query: should support multiple session IDs within one connection #1

katrinafyi opened this issue Jul 19, 2024 · 0 comments · May be fixed by #2

Comments

@katrinafyi
Copy link

According to https://wiki.vg/Query, the session ID is intended to identify requests within a connection. As such, multiple session IDs should be handled correctly.

Within https://github.com/mcstatus-io/demo-server/blob/d86be2555327fdc0dfcc5e190af4b8d14d3d53c6/src/query/packets.go, the session ID is used as a key for the challenge token map so varying the session ID leads to an invalid challenge token.

The vanilla server instead keys its challenges by the connected socket.

@katrinafyi katrinafyi linked a pull request Jul 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant