Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upvote button): reduced upvote button size and unintentional shrinking #31

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix(upvote button): reduced upvote button size and unintentional shrinking #31

wants to merge 2 commits into from

Conversation

vignesh-udhay
Copy link

  1. Upvoted button size: The width of the upvote button was reduced to be smaller than its height, creating a more compact appearance.
  2. Zero vote display: The number of votes is now displayed even when it's zero, making it clear that the button is for upvoting.
  3. Layout adjustments: The overall layout was modified, which unintentionally caused the upvote button to shrink in size.

Fixes #4 #5.

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vercel Vercel
Copy link

vercel bot commented Oct 10, 2024

@vignesh-udhay is attempting to deploy a commit to the MC Naveen's projects Team on Vercel.

A member of the Team first needs to authorize it.

@mcnaveen
Copy link
Owner

Hi @vignesh-udhay Thanks for the PR. I'm reviewing it now.
Btw, did you setup a hacktoberfest profile already?

@mcnaveen
Copy link
Owner

Nice work so far.

Could you fix one more thing? https://github.com/mcnaveen/liny/blob/dev/components/boards/card.tsx

gQUVQzvG4rQwat8e000050

@vignesh-udhay
Copy link
Author

Hi @vignesh-udhay Thanks for the PR. I'm reviewing it now. Btw, did you setup a hacktoberfest profile already?

No. I haven't set one up. Should I?

@vignesh-udhay
Copy link
Author

Fixed the board card issue and I've also created hacktoberfest profile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upvote button shrinks when desc is bigger
3 participants
@vignesh-udhay @CLAassistant @mcnaveen