Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nullable fields non-required in creation endpoints #240

Open
swrichards opened this issue Sep 10, 2024 · 0 comments
Open

Make nullable fields non-required in creation endpoints #240

swrichards opened this issue Sep 10, 2024 · 0 comments
Labels
enhancement New feature or request triage

Comments

@swrichards
Copy link

Thema / Theme

Klantinteracties API

Omschrijving / Description

The request here is to make all nullable fields in resource creation endpoints non-required.

Whenever fields are marked both as required and as {type} or null in creation endpoints, the field has to be explicitly included in the payload and set to null. If the field is omitted, a validation error is given.

For example, voorkeursDigitaalAdres in partijenCreate is defined in this way (required, but also accepts null in lieu of an object):

Screenshot from 2024-09-10 09-53-45

Omitting the field from a create payload yields:

Invalid parameters:
{'code': 'required',
 'name': 'voorkeursDigitaalAdres',
 'reason': 'Dit veld is vereist.'}

Which is fixed by adding:

"voorkeursDigitaalAdres" : null

If a field is nullable, then null is a sane default value that the API can set for the client, without having to explicate the fields in the payload.

Toegevoegde waarde / Added value

The current behavior is undesirable because it makes constructing requests very verbose and generally raises the friction of building a valid request. This is especially visible in tests, where the current approach leads to the need for a lot of factories and fixtures. I would say providing sane defaults wherever possible makes for a better developer experience.

Aanvullende opmerkingen / Additional context

No response

@swrichards swrichards added enhancement New feature or request triage labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage
Projects
Status: Triage
Development

No branches or pull requests

1 participant