Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PATCH doesn't support partial updates of the data of an object (bug and/or feature?) #466

Open
alextreme opened this issue Oct 9, 2024 · 2 comments
Assignees
Labels
approved bug Something isn't working owner: dimpact

Comments

@alextreme
Copy link
Member

Product versie / Product version

2.4.3

Omschrijf het probleem / Describe the bug

From @swrichards

Hello all, a quick sanity check regarding my expectations of how PATCH should work in the Objects API. My understanding is that I should be able to supply a partial record when using PATCH, that this partial should subsequently be merged with the existing object, and that new merged object should be validated according to the object type's JSON schema. Put differently: the object in the body of a PATCH should not itself have to be valid according to the JSON schema.

TLDR: the test I've written here should pass in my view, but instead I get a 400 with:

(Pdb) response.json()
{'non_field_errors': ["'diameter' is a required property"]}

Is my understanding of the expected behavior correct?

Stappen om te reproduceren / Steps to reproduce

No response

Verwacht gedrag / Expected behavior

No response

@joeribekker
Copy link
Member

@swrichards how blocking is this?

@swrichards
Copy link

@swrichards how blocking is this?

@joeribekker Practically speaking, for OIP, not at all -- this was important for the VNG hackathon, but we used a workaround and currently there are no (active) plans to integrate that work into the mainline, so don't raise its priority on our account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved bug Something isn't working owner: dimpact
Projects
Status: Todo
Development

No branches or pull requests

4 participants