Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Distortion #1

Closed
forrestpark opened this issue May 14, 2023 · 2 comments
Closed

Audio Distortion #1

forrestpark opened this issue May 14, 2023 · 2 comments

Comments

@forrestpark
Copy link
Collaborator

forrestpark commented May 14, 2023

Audio recordings made with distortions - sample recordings with distortions

The issue seems to be happening for a couple of other users of the 'audio-react-recorder' library. Link to issue

Depends on the device, but on the device currently deployed at the hospital, distortion starts to happen around the 7th or 8th consecutive recording with the distortion worsening afterwards.

I have tried modifying audio settings of audio-react-recorder (ex) and have attempted changing audio formats but have not been able to produce any meaningful improvement in audio quality.

'audio-react-recorder' does seem to be an abandoned library; have also explored other libraries as a last resort (ex). Please let me know if you have any recommendations on switching to another recording library, or potentially build one ourselves (expensive, though).

@ameriania
Copy link
Collaborator

Have you ever tried these two audio recorders as an alternative solution? You mentioned one of the below, maybe we can have a quick switch to a new library to test.

  1. react-audio-voice-recorder: https://github.com/samhirtarif/react-audio-recorder
  2. react-audio-analyser:https://github.com/jiwenjiang/react-audio-analyser

@ameriania
Copy link
Collaborator

Audio Distortion Follow Up

Distorted Voice Samples

Issue Address

Based on the related code I have reviewd, it seemds like there is none of our business when using the current provided libarary named audio-react-recorder, which leads to the distorted recording. One of alternative solutions is to use another library to rebuild the same feature, and it also help us way more easier to maintain the code in the later future. However, what we need to know is we can not guarantee it would not lead to distortion again, due to they are using very similar technique among each other.

Solutions

Library Demo Core Support Last
audio-react-recorder Demo1 React = 16 + getUserMedia wav 3 years
react-audio-recorder Demo2 React>=16.2.0 + mediaDevices wav/mp3/webm 5 days
react-audio-analyser Demo3 React = 16.4 + getUserMedia wav/mp3/webm 1 year

Browser Support

A really important information we need to know, no matter based on which technique we use, our recoding feature doesn't support IE browser. And we need to figure out what browsers are used in the hospital's scenario.
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants