Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON parse error #78

Closed
digitalbias opened this issue Feb 1, 2013 · 1 comment
Closed

JSON parse error #78

digitalbias opened this issue Feb 1, 2013 · 1 comment

Comments

@digitalbias
Copy link
Contributor

Something of a fringe case, but here goes:

When deleting a node from an index using "remove_node_from_index", if the value param is "" then the server returns a 404 message with an empty body. "handle_4xx_500_response" expects some JSON to return from the server, so you get a JSON error as opposed to some other kind of error from neography.

I've fixed it in my fork and can submit a pull request if that fits with how you want to handle it. Test spec is included.
@maxdemarzi
Copy link
Owner

Sure, send the pull request :) Thanks

@digitalbias digitalbias mentioned this issue Feb 1, 2013
Merged
maxdemarzi added a commit that referenced this issue Feb 1, 2013
@maxdemarzi
Merge pull request #79 from digitalbias/master
e59ab33 
Fix for issue #78
willkessler pushed a commit to willkessler/neography that referenced this issue Apr 21, 2014
@blizkreeg
Merge pull request maxdemarzi#78 from blizkreeg/models
5f04657 
change composed_attributes to track attribute with type and index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@digitalbias @maxdemarzi