Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Forwardable in Rest class to delegate API. #61

Merged
merged 1 commit into from
Sep 10, 2012

Conversation

rdvdijk
Copy link
Collaborator

@rdvdijk rdvdijk commented Sep 10, 2012

This finalizes all the Rest class refactoring. All argument defaults that were in left have been moved into the separate classes. There is hardly any logic left in the Rest class, and all API requests are delegated directly to the new classes.

@rdvdijk
Copy link
Collaborator Author

rdvdijk commented Sep 10, 2012

Whoops! Failing tests?.. let me fix that.

Update: I am getting failing tests now myself, but not those that Travis reports..

Very strange, the status seems to be missing from the batch request:

  1) Neography::Rest simple batch can delete a single relationship
     Failure/Error: batch_result[0]["status"].should == 201
       expected: 201
            got: nil (using ==)
     # ./spec/integration/rest_batch_spec.rb:152:in `block (3 levels) in <top (required)>'

  2) Neography::Rest referenced batch can create a relationship from a unique node
     Failure/Error: batch_result.should_not be_nil
       expected: not nil
            got: nil
     # ./spec/integration/rest_batch_spec.rb:432:in `block (3 levels) in <top (required)>'

@rdvdijk
Copy link
Collaborator Author

rdvdijk commented Sep 10, 2012

I'm not sure what happened, but I cannot reproduce the errors anymore.. (weird?)

@maxdemarzi
Copy link
Owner

Let's merge and see if it is just a fluke...

maxdemarzi added a commit that referenced this pull request Sep 10, 2012
Use Forwardable in Rest class to delegate API.
@maxdemarzi maxdemarzi merged commit b80126e into maxdemarzi:master Sep 10, 2012
willkessler pushed a commit to willkessler/neography that referenced this pull request Apr 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants