Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock rubyzip to 0-9-x-stable #107

Merged
merged 1 commit into from
Aug 29, 2013
Merged

Lock rubyzip to 0-9-x-stable #107

merged 1 commit into from
Aug 29, 2013

Conversation

wcamarao
Copy link
Contributor

rubyzip has introduced breaking changes on 1.0.0 as per rubyzip/rubyzip@61ce5db

Since neography.gemspec uses >= for dependency versions, new installation of dependencies bring rubyzip 1.0.0 and therefore neography breaks.

Here's the output before this fix:

$ bundle
$ bundle exec rake

rake aborted!
cannot load such file -- zip/zip
/Users/wagner/Projects/os/neography/lib/neography/tasks.rb:4:in `require'
/Users/wagner/Projects/os/neography/lib/neography/tasks.rb:4:in `<top (required)>'
/Users/wagner/Projects/os/neography/Rakefile:5:in `require'
/Users/wagner/Projects/os/neography/Rakefile:5:in `<top (required)>'

And here's the output after this fix:

$ bundle exec rake

(hiding verbose output...)

Finished in 12.83 seconds
624 examples, 0 failures
[Coveralls] Outside the Travis environment, not sending data.

Since I could only proof the issue with rubyzip, I only changed rubyzip in neography.gemspec. However that'd be nice to make the same change (replacing >= with ~>) for all the other dependencies as well.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 2b98eba on wcamarao:fix into b7985ae on maxdemarzi:master.

maxdemarzi added a commit that referenced this pull request Aug 29, 2013
Lock rubyzip to 0-9-x-stable
@maxdemarzi maxdemarzi merged commit 2926a43 into maxdemarzi:master Aug 29, 2013
@maxdemarzi
Copy link
Owner

Thanks!

@wcamarao
Copy link
Contributor Author

Neat. Would you please publish this on ruby gems?

@maxdemarzi
Copy link
Owner

Just released 1.1.3

@wcamarao
Copy link
Contributor Author

Wonderful, thanks!

@simonoff
Copy link
Contributor

Why not change code to new version? It's not so hard. Only require 'zip/filesystem' and remove Zip prefix in class names.

@pboling
Copy link
Contributor

pboling commented Aug 31, 2013

👍 to bumping rubyzip version IFF it is done in at least a minor version bump of neography

Further discussion is and should be here

willkessler pushed a commit to willkessler/neography that referenced this pull request Apr 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants