Add NodeRelationships specs.

lib/neography/rest/node_relationships.rb

@@ -12,31 +12,32 @@ def initialize(connection)
         @connection = connection
       end
 
-      def create(type, from, to, props)
+      def create(type, from, to, properties)
         options = {
           :body => {
             :to => @connection.configuration + "/node/#{get_id(to)}",
-            :data => props,
+            :data => properties,
             :type => type
           }.to_json,
           :headers => json_content_type }
 
         @connection.post(base_path(:id => get_id(from)), options)
       end
 
-      def get(id, direction, types)
-        direction = get_direction(direction)
+      def get(id, direction = nil, types = nil)
+        direction = parse_direction(direction)
 
         if types.nil?
           node_relationships = @connection.get(direction_path(:id => get_id(id), :direction => direction)) || []
         else
           node_relationships = @connection.get(type_path(:id => get_id(id), :direction => direction, :types => Array(types).join('&'))) || []
         end
+
         return nil if node_relationships.empty?
         node_relationships
       end
 
-      def get_direction(direction)
+      def parse_direction(direction)
         case direction
           when :incoming, "incoming", :in, "in"
             "in"

spec/matchers.rb

@@ -0,0 +1,16 @@
+# Convenience matcher for matching JSON fields with a hash
+RSpec::Matchers.define :json_match do |field, expected|
+
+  match do |actual|
+    expected == JSON.parse(actual[field])
+  end
+
+  failure_message_for_should do
+    "expected JSON in field '#{@field}' to not match '#{@expected}'"
+  end
+
+  description do
+    "JSON in field '#{field}' should match '#{expected.inspect}'"
+  end
+
+end

spec/spec_helper.rb

@@ -1,5 +1,6 @@
 require 'neography'
 require 'benchmark'
+require 'matchers'
 
 # If you want to see more, uncomment the next few lines
 # require 'net-http-spy'
@@ -17,6 +18,7 @@ def generate_text(length=8)
   c.filter_run_excluding :slow => true, :break_gremlin => true
 end
 
+
 def json_content_type
   {"Content-Type"=>"application/json"}
 end

spec/unit/rest/node_relationships_spec.rb

@@ -0,0 +1,62 @@
+require 'spec_helper'
+
+module Neography
+  class Rest
+    describe NodeRelationships do
+
+      let(:connection) { stub(:configuration => "http://configuration") }
+      subject { NodeRelationships.new(connection) }
+
+      it "creates a relationship" do
+        body_hash = { "type" => "some_type",
+          "to" => "http://configuration/node/43",
+          "data" => {"foo"=>"bar","baz"=>"qux"}
+        }
+        connection.should_receive(:post).with("/node/42/relationships", json_match(:body, body_hash))
+
+        subject.create("some_type", "42", "43", {:foo => "bar", :baz => "qux"})
+      end
+
+      it "gets relationships" do
+        connection.should_receive(:get).with("/node/42/relationships/all")
+        subject.get("42")
+      end
+
+      it "gets relationships with direction" do
+        connection.should_receive(:get).with("/node/42/relationships/in")
+        subject.get("42", :in)
+      end
+
+      it "gets relationships with direction and type" do
+        connection.should_receive(:get).with("/node/42/relationships/in/foo")
+        subject.get("42", :in, "foo")
+      end
+
+      it "gets relationships with direction and types" do
+        connection.should_receive(:get).with("/node/42/relationships/in/foo&bar")
+        subject.get("42", :in, ["foo", "bar"])
+      end
+
+      context "directions" do
+
+        [ :incoming, "incoming", :in, "in" ].each do |direction|
+          it "parses 'in' direction" do
+            NodeRelationships.new(nil).parse_direction(direction).should == "in"
+          end
+        end
+
+        [ :outgoing, "outgoing", :out, "out" ].each do |direction|
+          it "parses 'out' direction" do
+            NodeRelationships.new(nil).parse_direction(direction).should == "out"
+          end
+        end
+
+        it "parses 'all' direction by default" do
+          NodeRelationships.new(nil).parse_direction("foo").should == "all"
+        end
+
+      end
+
+    end
+  end
+end